Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward compatibility with Stream v1.0 and v0.7 #184

Merged
merged 2 commits into from
May 15, 2017

Conversation

clue
Copy link
Member

@clue clue commented May 13, 2017

Builds on top of #183

@clue clue added this to the v0.7.0 milestone May 13, 2017
@clue
Copy link
Member Author

clue commented May 15, 2017

Updated to simplify buffering tests by using new react/promise-stream release :shipit:

@WyriHaximus
Copy link
Member

@clue changes look good, but any idea why the lowest builds are failing?

@clue
Copy link
Member Author

clue commented May 15, 2017

@WyriHaximus Updated the first commit to target at least react/stream v0.4.6 which contains a bugfix for the ThroughStream that is now used in the test suite :shipit:

@WyriHaximus
Copy link
Member

Cheers 👍

@WyriHaximus WyriHaximus merged commit 01332ae into reactphp:master May 15, 2017
@clue clue deleted the stream branch May 15, 2017 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants